[Simh] {Simh] A few more bugs found

[Armistead, Jason]

Just thinking out loud ...

Has anyone run SIMH through any form of static code analysis tool, and would it perhaps uncover some more previously-undetected bugs ?

In suggesting this, I realize that these static analysis tools often generate a lot of "noise" in their output too, but it might catch some of these issues that have escaped our eyes to date.

Jason

-----Original Message-----
From: simh-bounces at trailing-edge.com [mailto:simh-bounces at trailing-edge.com] On Behalf Of Bob Supnik
Sent: Wednesday, 21 March 2012 4:10 PM
To: simh at trailing-edge.com
Subject: Re: [Simh] {Simh] A few more bugs found

I'm only going to comment on my own code.

2. id_pas.c - this is real. The tests should be against TTUF_MODE_8B. 
Will be fixed in 3.9.

4. pdp1_cpu.c, Ea_ch. Also real, the & should be && in that statement. 
Will be fixed in 3.9.

6. pdp1_stddev.c, tto_svc. Also real. The code will be restructured so that c is only referenced inside the else {} statement. Will be fixed in 3.9

9. i1401_iq.c. Also real. The return should be commented out as well. 
Already fixed in the 3.9 code base.

/Bob
_______________________________________________
Simh mailing list
Simh at trailing-edge.com
http://mailman.trailing-edge.com/mailman/listinfo/simh